Select menu types #707
Merged
Select menu types #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukellmann
added
the
hacktoberfest-accepted
NoComment1105
approved these changes
Nov 8, 2022
lukellmann
requested changes
Nov 8, 2022
|
Do you have unpushed changes for this? Since you already marked the comments as resolved. |
Yes! I'll try to make commit later today |
lukellmann
approved these changes
Nov 13, 2022
|
Sure |
|
It's ok for me. |
|
Alright, thanks! |
lukellmann
added a commit
that referenced
this pull request
Nov 17, 2022
The deprecations for SelectMenuBuilder.options and SelectMenuComponent.options were propagated to the overrides in StringSelectBuilder and StringSelectComponent when a user of Kord didn't have progressive mode enabled. To fix this, extensions are provided instead. The changes in the public API are binary incompatible compared to #707 but not compared to 0.8.0-M17 so only snapshot users can be affected. see #707, https://youtrack.jetbrains.com/issue/KT-47902 and https://discord.com/channels/556525343595298817/587324906702766226/1042799716745879643
lukellmann
added a commit
that referenced
this pull request
Nov 17, 2022
The deprecations for SelectMenuBuilder.options and SelectMenuComponent.options were propagated to the overrides in StringSelectBuilder and StringSelectComponent when a user of Kord didn't have progressive mode enabled. To fix this, extensions are provided instead. The changes in the public API are binary incompatible compared to #707 but not compared to 0.8.0-M17 so only snapshot users can be affected. see #707, https://youtrack.jetbrains.com/issue/KT-47902 and https://discord.com/channels/556525343595298817/587324906702766226/1042799716745879643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major API changes are:
ComponentType.SelectMenutoComponentType.StringSelectComponentTypes:UserSelect,RoleSelect,MentionableSelectandChannelSelectSelectMenuComponentsubtype for each select menu typeActionRowBuildersee discord/discord-api-docs#5543 and discord/discord-api-docs#5544