Upgrade to Gradle 8.0 #755
Conversation
The changes in gradle-wrapper.jar, gradle-wrapper.properties and gradlew are the result of running this command twice: ./gradlew wrapper --gradle-version 8.0 --gradle-distribution-sha256-sum f30b29580fe11719087d698da23f3b0f0d04031d8995f7dd8275a31f7674dc01 While touching the build files, the following was also done: * use Java toolchains, see https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support * use the new compilerOptions DSL introduced in Kotlin 1.8.0, see https://kotlinlang.org/docs/whatsnew18.html#exposing-kotlin-compiler-options-as-gradle-lazy-properties Running the dokkaHtmlMultiModule task is not possible with Dokka 1.7.20 and Gradle 8.0 due to Kotlin/dokka#2796. This will prevent us from publishing Dokka docs until a fix is released.
withType<TaskType> { ... } creates tasks eagerly and should be replaced
by withType<TaskType>().configureEach { ... }, see
https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#sec:old_vs_new_configuration_api_overview
For some strange reason this approach fails with a
ConcurrentModificationException when used for
withType<KotlinCompile>().configureEach { ... } but only inside of
kord-module.gradle.kts.
We need to move that step down in order, because Gradle will fail with a ConcurrentModificationException during task dependency calculation otherwise
This reverts commit beb4c0d.
I talked with @DRSchlaubi and it doesn't seem to be easily fixable. However, before merging this I suggest to wait for the next Dokka release so we are able to publish docs. |
Are there nightly builds, as Kotlin/dokka#2796 has been fixed for a while? |
DRSchlaubi
added
the
on hold
idk, would have to dig around in their build setup to be sure |
haven't found anything in the documentation |
|
Ok, there are some dev builds: Kotlin/dokka#1425 I suggest we update to one of those, dokka is only used internally, so this won't affect users. |
|
Yeah sounds good to me |
DRSchlaubi
removed
the
on hold
* Gradle 8.0 -> 8.0.2 * Kotlin 1.8.0 -> 1.8.10 * KSP 1.8.0-1.0.8 -> 1.8.10-1.0.9 * Ktor 2.2.1 -> 2.2.4 * kotlinx.serialization 1.4.1 -> 1.5.0 * Dokka 1.8.0-dev-194 -> 1.8.10 * AtomicFU 0.19.0 -> 0.20.0 * Binary compatibility validator 0.12.1 -> 0.13.0 * JUnit 5 5.9.1 -> 5.9.2 * MockK 1.13.2 -> 1.13.4 The wrapper task is no longer configured to use the all distribution type. This results in smaller downloads (e.g. in CI) while still being able to inspect sources in IntelliJ (they are downloaded automatically). Nothing is serializable since Kotlin 1.8.0 and kotlinx.serialization 1.5.0-RC which means dev.kord.common.entity.DiscordNull and dev.kord.gateway.NullDecoder are now obsolete. Kotlin/dokka#2796 was fixed with Dokka 1.8.10, which means the dev build used since #755 is no longer needed and the corresponding maven repository was removed from the build files.
* Gradle 8.0 -> 8.0.2 * Kotlin 1.8.0 -> 1.8.10 * KSP 1.8.0-1.0.8 -> 1.8.10-1.0.9 * Ktor 2.2.1 -> 2.2.4 * kotlinx.serialization 1.4.1 -> 1.5.0 * Dokka 1.8.0-dev-194 -> 1.8.10 * AtomicFU 0.19.0 -> 0.20.0 * Binary compatibility validator 0.12.1 -> 0.13.0 * JUnit 5 5.9.1 -> 5.9.2 * MockK 1.13.2 -> 1.13.4 The wrapper task is no longer configured to use the all distribution type. This results in smaller downloads (e.g. in CI) while still being able to inspect sources in IntelliJ (they are downloaded automatically). Nothing is serializable since Kotlin 1.8.0 and kotlinx.serialization 1.5.0-RC which means dev.kord.common.entity.DiscordNull and dev.kord.gateway.NullDecoder are now obsolete. Kotlin/dokka#2796 was fixed with Dokka 1.8.10, which means the dev build used since #755 is no longer needed and the corresponding maven repository was removed from the build files.
The changes in
gradle-wrapper.jar,gradle-wrapper.propertiesandgradleware the result of running this command twice:While touching the build files, the following was also done:
use Java toolchains, see https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support
use the new compilerOptions DSL introduced in Kotlin 1.8.0, see https://kotlinlang.org/docs/whatsnew18.html#exposing-kotlin-compiler-options-as-gradle-lazy-properties
Running the- Using dev build instead.dokkaHtmlMultiModuletask is not possible with Dokka 1.7.20 and Gradle 8.0 due to Kotlin/dokka#2796. This will prevent us from publishing Dokka docs until a fix is released.