Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avatar_decoration to user #852

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Add avatar_decoration to user #852

merged 4 commits into from
Aug 3, 2023

Conversation

NoComment1105
Copy link
Contributor

@lukellmann
Copy link
Member

this should also have an Asset in core like User.avatar

lukellmann
lukellmann requested changes Aug 2, 2023
View reviewed changes
common/src/commonMain/kotlin/entity/DiscordUser.kt Outdated Show resolved Hide resolved
common/src/commonMain/kotlin/entity/DiscordUser.kt Outdated Show resolved Hide resolved
core/src/commonMain/kotlin/entity/Asset.kt Outdated Show resolved Hide resolved
lukellmann
lukellmann approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@lukellmann lukellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@lukellmann lukellmann merged commit 892a770 into kordlib:main Aug 3, 2023
3 checks passed
@NoComment1105 NoComment1105 deleted the avatar-decorations branch August 7, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukellmann lukellmann lukellmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NoComment1105 @lukellmann