Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom status #857

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Implement custom status #857

merged 9 commits into from
Aug 23, 2023

Conversation

DRSchlaubi
Copy link
Member

@DRSchlaubi DRSchlaubi commented Aug 9, 2023

@DRSchlaubi
Copy link
Member Author

Seems like I botched that commit message whoops

@DRSchlaubi DRSchlaubi changed the title Enable signing if possible @DRSchlaubi Implement custom status Aug 10, 2023
@DRSchlaubi DRSchlaubi changed the title @DRSchlaubi Implement custom status Implement custom status Aug 10, 2023
Copy link
Member

@lukellmann lukellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also seems like state can be set on other activity types, so a parameter should probably be added to the other functions in PresenceBuilder

gateway/src/commonMain/kotlin/builder/PresenceBuilder.kt Outdated Show resolved Hide resolved
Co-authored-by: lukellmann <47486203+lukellmann@users.noreply.github.com>
@DRSchlaubi
Copy link
Member Author

it also seems like state can be set on other activity types, so a parameter should probably be added to the other functions in PresenceBuilder

It's a var in the presence builder, so you should be able to do

kord.editPresence {
  state = "HI"
  playing("game")
}

@DRSchlaubi
Copy link
Member Author

@DRSchlaubi DRSchlaubi marked this pull request as ready for review August 12, 2023 15:54
@DRSchlaubi
Copy link
Member Author

@lukellmann blob's PR was merged so is this ready?

@lukellmann
Copy link
Member

@lukellmann blob's PR was merged so is this ready?

see latest review about the issue i still see

@lukellmann lukellmann merged commit 59d83d9 into main Aug 23, 2023
8 checks passed
@lukellmann lukellmann deleted the feature/custom-statuc branch August 23, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants