Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction permissions to MemberData and Member #884

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Tmpod
Copy link
Contributor

@Tmpod Tmpod commented Oct 13, 2023

Fixes #664

I'm unsure if the Optional vs null usage is in line with the project's preferences, please correct me if it isn't!

Copy link
Member

@lukellmann lukellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a small documentation nit

i think using Optional is the right choice here

core/src/commonMain/kotlin/entity/Member.kt Outdated Show resolved Hide resolved
@Tmpod Tmpod force-pushed the task/664/member-perms-field branch from a34a521 to 31b2a7b Compare October 13, 2023 15:14
Copy link
Member

@lukellmann lukellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@lukellmann lukellmann merged commit 78a9fbb into kordlib:main Oct 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing interactions permissions field on Kord Core's Member object
2 participants