Rewrite Event.DeserializationStrategy
#923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More details and tests will follow. Fixes #922
Don't differentiate between missing and null d field for UnknownDispatchEventEvent.
DRSchlaubi
approved these changes
Mar 15, 2024
Co-authored-by: Michael Rittmeister <michael@rittmeister.in>
lukellmann
added a commit
that referenced
this pull request
Mar 16, 2024
To keep the diff reasonable, I left this out of #923.
lukellmann
added a commit
that referenced
this pull request
Mar 16, 2024
Similar to #923 but for the voice gateway.
lukellmann
added a commit
that referenced
this pull request
Mar 16, 2024
Some tests added in #923 seem to time out on Kotlin/JS. To avoid problems like this in the future, this commit disables test timeouts on Kotlin/JS completely.
DRSchlaubi
pushed a commit
that referenced
this pull request
Mar 16, 2024
Some tests added in #923 seem to time out on Kotlin/JS. To avoid problems like this in the future, this commit disables test timeouts on Kotlin/JS completely.
DRSchlaubi
pushed a commit
that referenced
this pull request
Mar 16, 2024
To keep the diff reasonable, I left this out of #923.
DRSchlaubi
pushed a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing
Events,Event.DeserializationStrategyassumed that thedfield was the last field to be observed. If it wasn't the last field, the deserialization could fail in two ways:tandsfields were ignored if they came after thedfieldopfield came after thedfieldTo fix these possible failure cases, the deserialization logic has been changed to work in two steps:
dfield as a plainJsonElementEventfrom theJsonElement, depending on the values of theop,tandsfieldsThe supertype of
Event.DeserializationStrategyhas also been changed fromDeserializationStrategy<Event?>toDeserializationStrategy<Event>-deserializeno longer returnsnullin some cases of illegal event payloads, but throws exceptions instead.Fixes #922