Fix test related Gradle deprecation warnings #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following deprecation warnings have been fixed: > Task :common:jvmTest The automatic loading of test framework implementation dependencies has been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the desired test framework directly on the test suite or explicitly declare the test framework implementation dependencies on the test's runtime classpath. Consult the upgrading guide for further information: https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#test_framework_implementation_dependencies -> fixed by adding an explicit runtimeOnly dependency on org.junit.platform:junit-platform-launcher > Task :core:live-tests:jvmTest No test executed. This behavior has been deprecated. This will fail with an error in Gradle 9.0. There are test sources present but no test was executed. Please check your test configuration. Consult the upgrading guide for further information: https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#test_task_fail_on_no_test_executed -> fixed by configuring Test tasks with useJUnitPlatform() in kord-internal-multiplatform-module (used by :core:live-tests) org.gradle.warning.mode was set to all to verify that these deprecation warnings are indeed fixed on CI.
DRSchlaubi
approved these changes
Apr 13, 2024
lukellmann
added a commit
that referenced
this pull request
Apr 17, 2024
I accidentally reintroduced them in the most recent merge of main into feature/native.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following deprecation warnings have been fixed:
-> fixed by adding an explicit
runtimeOnlydependency onorg.junit.platform:junit-platform-launcher-> fixed by configuring
Testtasks withuseJUnitPlatform()inkord-internal-multiplatform-module(used by:core:live-tests)org.gradle.warning.modewas set toallto verify that these deprecation warnings are indeed fixed on CI.