Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty replicaset metrics #119

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: empty replicaset metrics #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 29 additions & 25 deletions src/app/backend/model/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,37 +129,41 @@ func GetWorkloadCumulativeMetrics(cluster string, namespace string, resource str
} else {
return nil, errors.New(fmt.Sprintf("unsupported resource '%s'", resource))
}
names := []string{}
for _, pd := range pods {
names = append(names, pd.ObjectMeta.Name)
}
if len(pods) > 0 {
names := []string{}
for _, pd := range pods {
names = append(names, pd.ObjectMeta.Name)
}

metricsClient := clientSet.NewCumulativeMetricsClient()
metricsClient := clientSet.NewCumulativeMetricsClient()

selector := client.CumulativeMetricsResourceSelector{
Pods: names,
Namespace: namespace,
Function: "AVG",
}
selector := client.CumulativeMetricsResourceSelector{
Pods: names,
Namespace: namespace,
Function: "AVG",
}

result := CumulativeMetrics{}
// invoke metrics-scraper api
metrics, err := metricsClient.Get(selector)
if err != nil {
return nil, err
}
result.Metrics = metrics
result := CumulativeMetrics{}
// invoke metrics-scraper api
metrics, err := metricsClient.Get(selector)
if err != nil {
return nil, err
}
result.Metrics = metrics

// get request, limit
for _, c := range podSpec.Containers {
result.Limits.CPU = result.Limits.CPU + c.Resources.Limits.Cpu().MilliValue()
result.Limits.Memory = result.Limits.Memory + c.Resources.Limits.Memory().Value()
result.Requests.CPU = result.Requests.CPU + c.Resources.Requests.Cpu().MilliValue()
result.Requests.Memory = result.Requests.Memory + c.Resources.Requests.Memory().Value()
}

// get request, limit
for _, c := range podSpec.Containers {
result.Limits.CPU = result.Limits.CPU + c.Resources.Limits.Cpu().MilliValue()
result.Limits.Memory = result.Limits.Memory + c.Resources.Limits.Memory().Value()
result.Requests.CPU = result.Requests.CPU + c.Resources.Requests.Cpu().MilliValue()
result.Requests.Memory = result.Requests.Memory + c.Resources.Requests.Memory().Value()
return &result, nil
} else {
return &CumulativeMetrics{}, nil
}

return &result, nil

}

// get pod list with metrics
Expand Down