Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiwindow / free mode support. #238

Open
pazos opened this issue Jul 7, 2020 · 3 comments
Open

Multiwindow / free mode support. #238

pazos opened this issue Jul 7, 2020 · 3 comments

Comments

@pazos
Copy link
Member

pazos commented Jul 7, 2020

Mostly useful for ChromeOS or big tablets. Doesn't make much sense in a phone/e-ink device.

Android docs in https://developer.android.com/guide/topics/ui/multi-window.

Some notes:

  1. Resize when the app has a native window to draw. That happens on ChromeOS when we're resizing but not on Android. On android resizing needs to happen in onStart() or when we have focus back, not onConfigurationChanged() No longer true since refactor MainActivity, backport android_native_glue changes from r22 #257 (use APP_CMD_WINDOW_RESIZED instead)
  2. Disable fullscreen layout while in multiwindow mode. Also need to take constraints into account to calculate width and height (to avoid draw on top of the menu bar)
  3. width and height in multiwindow mode are calculated based on reported data by window.decorView. Current implementations of android.getScreenWidth() and android.getScreenHeight will return bogus values. No longer relevant since we get the true values from surfaceChanged callback.

I will label as won't fix because I won't but PR are indeed very welcome.

@HoanPiTa
Copy link

I just wanna to read a book in 2 languages in a time.

@pazos
Copy link
Member Author

pazos commented Mar 20, 2021

I just wanna to read a book in 2 languages in a time.

I'm afraid you'll need another program. There're plenty of them in android and most should support multiple instances :)

@HoanPiTa
Copy link

I just wanna to read a book in 2 languages in a time.

I'm afraid you'll need another program. There're plenty of them in android and most should support multiple instances :)
Yes. I am using Neo reader, moon reader for 2 book in a time. But i like koreader :((

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants