Black stripe on the buttom of the screen

[672493]

• KOReader version:
• Device:

Issue

Starting from this version

there is a black stripe on the buttom of the screen when show cutout in system settings is turned on. On this version

everything is ok

Steps to reproduce

This bug appears If show cutout in system setting is turned on

crash.log (if applicable)

crash.log is a file that is automatically created when KOReader crashes. It can normally be found in the KOReader directory:

• /mnt/private/koreader for Cervantes
• koreader/ directory for Kindle
• .adds/koreader/ directory for Kobo
• applications/koreader/ directory for Pocketbook

Android logs are kept in memory. Please go to [Menu] → Help → Bug Report to save these logs to a file.

Please try to include the relevant sections in your issue description.
You can upload the whole crash.log file (zipped if necessary) on GitHub by dragging and dropping it onto this textbox.

If your issue doesn't directly concern a Lua crash, we'll quite likely need you to reproduce the issue with verbose debug logging enabled before providing the logs to us.
To do so, from the file manager, go to [Tools] → More tools → Developer options, and tick both Enable debug logging and Enable verbose debug logging.
You'll need to restart KOReader after toggling these on.

If you instead opt to inline it, please do so behind a spoiler tag:

crash.log

<Paste crash.log content here>

[pazos]

Yay, use auto or stick with the last version that works for you

[672493]

If I use auto that black line appears on top in the notch area) and the program does not extend to full screen also

[pazos]

Yes, that's the behaviour we're looking for. Top blank line. Bottom matches screen

[672493]

Thank you! But it does not look consistent with white screen and black font. Why not to extend the program window fullscreen, as it was a few versions ago?

[pazos]

You were exploiting an undefined behaviour on the application. We fixed that. The app worked the same since we added support for notches, in #4769

Now, I truly don't know how it behaved on your device, with "auto" set, on previous versions. But that was also undefined if your device has android>=13.

Anyhow, please use the old version if that is what you want. I'm using a v2022 on my main reader device and have no FOMO whatsoever ;)

[672493]

Thank you, everything is clear), anyway, on my device this patch works fine #10698 (comment)
Thank you

[pazos]

Thank you, everything is clear), anyway, on my device this patch works fine #10698 (comment) Thank you

Yup, as long as you always read in portrait mode.
It might be possible to get another patch that takes width into account and works also in landscape mode. If somebody figures out a patch like that let us know :)

[hugleo]

For what I understood, your device doesn't have a hole, right?
For tests on the emulator, there was no black strip when I tested. However, I just tested with the previous options before I deduplicate:

if (cut != null && cut.boundingRects.isNotEmpty())

I didn't test with:

if (cut != null)

Maybe cut.boundingRects.isNotEmpty() makes some difference. I shall test again on the emulator. If that breaks on the emulator, we can fix that. Otherwise, @pazos would be a good idea to have a koreader option that lets the user choose to ignore or not the cutout area?

@672493, what is your device

[pazos]

@hugleo: please, no.

It is not possible ATM unless you address koreader/android-luajit-launcher#238 properly first

[hugleo]

@hugleo: please, no.

It is not possible ATM unless you address koreader/android-luajit-launcher#238 properly first

unless you address koreader/android-luajit-launcher#238 properly first

Suffering succotash :)

It is not possible ATM unless you address koreader/android-luajit-launcher#238 properly first

Suffering succotash :)

[672493]

@672493, what is your device

This is Huawei p60 pro. It has a notch and curved corners, but I try to ignore it)

[hugleo]

All right, no bugs on our side then. The black strip is intended to cover the notch area so that Koreader contents aren't cut off, such as image edges or text letters.