-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SurfaceView override. #143
Conversation
to be able to interact with the epd driver via known android view methods, like invalidate() or postInvalidate()
Looks fine to me in any case. ;-) |
Edit: UUoops... i didn't check the install (failed). So it's the 386 build indeed. I'll do it again with the ARM apk |
Thanks for the log. It throws an error that seems unrelated to the changes in this PR, but I'm not sure. Pinging @Frenzie @NiLuJe
|
That's in |
Ah, the koreader asset package in the APK is not up-to-date, for some reason? (Well, it has a recent tag, and recent timestamps, but the content isn't up to date). Is you base branch properly rebased, @pazos? |
@NiLuJe nope, now I rebased and find a new build error
Until now I worked w/ the sdk/ndk downloaded by KOReader but now it seems that I need to export the toolchain binpath. Is that intended? |
That's a warning we've caught on the CIs, too, it's apparently mostly harmless, though, but I'm not sure exactly where it's coming from. The obvious guess would be shell CC calls in the makefile, but they should all be enforcing PATH now... It more or less matches stupid warnings from CCache on other platforms, FWIW. I can't reproduce any of it, but then I don't use ccache, and the compilers are always in my $PATH ;). |
thanks for the feedback @hugleo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said, lgtm :-)
in order to interact with the epd driver indirectly, via the View class framework, where the epd driver is hooked.
This is part of the solution proposed in koreader/koreader#3517 (comment) to add support for tolinos, but should be compatible with other devices based on the freescale platform.
All credits to @char11, thanks pal!
Things are working fine on the emulator/phone, but I lack a eink device to test.
Please @hugleo, @carlinux, @Cellaris (or anybody with a currently supported eink device) , could you test https://www.dropbox.com/s/froawrgv4jt6h1p/koreader-android-arm-linux-androideabi-debug-v2019.04-52-g7d742e15_2019-04-22.apk?dl=0 and report if eink updates still work?. Also extra points for the output of
adb logcat -c && adb logcat KOReader:D *:S
Waiting for feedback before requesting reviews, and so on. If this build still works on Rockchip devices it will be wonderful 👍