better legacy icons, append application suffix to debug version, diff… #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adaptative icons need some love too. Are these ok? They're basically (here goes a white image without background :p) with a color background. Didn't manage to get the vertical white line on the right because that's made with 2 overlapped figures. |
|
I don't quite understand why we need all of those? But that aside, sure. |
Because we can provide better icons than some random launcher that enforces specific shapes using as a base the legacy icon. Normally apps can't do a good job and just scale the icon to fit in the shape and apply the primary color of the icon as a background. Do note that apps cannot enforce how their icons look. It is up to the apps that are presenting them to pick adaptative, legacy or custom shape icons for each app they're listing. |
pazos
force-pushed
the
refactor_flavors
branch
from
6e3a345
to
1f6ace0
Compare
|
@Frenzie: IIRC The two exceptions that are still outside default paths are |
Er, that's what it's for? |
|
Cool. TBH I didn't test
It is probably a github thingy, which doesn't preserve history: see for the same file: https://github.com/pazos/android-luajit-launcher/commits/refactor_flavors/app/src/main/java/org/koreader/launcher/device/epd/qualcomm/QualcommEPDController.kt |
|
Blame works fine though, also on the GH UI. Anyway, so assuming you used |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 23, 2020
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 23, 2020
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Dec 24, 2020
* Android: Don't mark the platform as should_restrict_JIT And see how much stuff breaks \o/ * Prevent Android users from disabling the C blitter, regardless of the restrict flag * Update android-luajit-launcher koreader/android-luajit-launcher#278 koreader/android-luajit-launcher#275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… by icon color
Idea cherry picked from ildar@db92ce2
Adding app suffix makes possible to have the release and debug version installed at the same time. Until now one was called KOReader and the other KOReader-debug. Log names changed the same way and I was always puzzled until I realized I need to do
adb logcat KOReader-debug:Din debug versions.Now both are called "KOReader" but the debug version has a red icon instead.
The release version keep its package name
org.koreader.launcherand the debug version has a package namedorg.koreader.launcher.debugAlso improved legacy icons, so they keep their original shape and are not squarefied.
pre-commit
post-commit
This change is