Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak 64bit builds #390

Merged
merged 4 commits into from Oct 24, 2022
Merged

Unbreak 64bit builds #390

merged 4 commits into from Oct 24, 2022

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Oct 17, 2022

The MultiDexApplication stuff changed in ABI 21+, which breaks if we use minSdk 21...

But, apparently, we can build with an NDKABI > minSdk, so, do that ;p.

(c.f., koreader/koreader#9632 (comment))


This change is Reviewable

Because apparently something as stupid as this requires jumping through
seven hoops?
This reverts commit edd9ae3.

Yeah, fuck it just use jit.arch ;o).
@pazos
Copy link
Member

pazos commented Oct 17, 2022

The unfortunate chain of events is:

  1. Added support for 64 bit builds on this repo a couple of years ago
  2. Enabled D8 to save a few KBs a few months later
  3. D8 requires a "desugaring" library.
  4. The desugaring library requires multidex support.

Here we are. Maybe for 200kb doesn't worth the hussle and we can get rid of multidex + desugaring?

In any case, LGTM

@NiLuJe
Copy link
Member Author

NiLuJe commented Oct 17, 2022

2. Enabled D8 to save a few KBs a few months later

3. D8 requires a "desugaring" library.

4. The desugaring library requires multidex support.

Here we are. Maybe for 200kb doesn't worth the hussle and we can get rid of multidex + desugaring?

I have no clue what any of these things are ;o).

@pazos
Copy link
Member

pazos commented Oct 17, 2022

I have no clue what any of these things are ;o).

Me too.

But I know what they do: magic to strip a few kb out of the apk.

After a quick skim of various opensource apps I think we're fine with this PR alone

could you remove instead of comment?

Copy link
Member Author

@NiLuJe NiLuJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)

@NiLuJe NiLuJe merged commit 96d7478 into koreader:master Oct 24, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 24, 2022
NiLuJe added a commit to koreader/koreader that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants