New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak 64bit builds #390
Unbreak 64bit builds #390
Conversation
Because apparently something as stupid as this requires jumping through seven hoops?
This reverts commit edd9ae3. Yeah, fuck it just use jit.arch ;o).
The unfortunate chain of events is:
Here we are. Maybe for 200kb doesn't worth the hussle and we can get rid of multidex + desugaring? In any case, LGTM |
I have no clue what any of these things are ;o). |
Me too. But I know what they do: magic to strip a few kb out of the apk. After a quick skim of various opensource apps I think we're fine with this PR alone could you remove instead of comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
The
MultiDexApplication
stuff changed in ABI 21+, which breaks if we use minSdk 21...But, apparently, we can build with an NDKABI > minSdk, so, do that ;p.
(c.f., koreader/koreader#9632 (comment))
This change is