Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onyx Tab Ultra Color support #431

Merged
merged 6 commits into from Dec 22, 2023
Merged

Onyx Tab Ultra Color support #431

merged 6 commits into from Dec 22, 2023

Conversation

hugleo
Copy link
Contributor

@hugleo hugleo commented Aug 6, 2023

Add support to Onyx Tab Ultra Color


This change is Reviewable

Add support to Onyx Tab Ultra Color
@pazos
Copy link
Member

pazos commented Aug 6, 2023

Hey, thanks for the patch.

Color devices need to specify that too, so won't loose color when being treated as EinkDevices.

See https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/device/DeviceInfo.kt#L686

@hugleo
Copy link
Contributor Author

hugleo commented Aug 6, 2023

Hey, thanks for the patch.

Color devices need to specify that too, so won't loose color when being treated as EinkDevices.

See https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/device/DeviceInfo.kt#L686

Bu it's already doing in my patch:

EinkDevice.ONYX_TAB_ULTRA_C -> true

@pazos
Copy link
Member

pazos commented Aug 6, 2023

ap, sorry.

I didn't catch it after a quick skim :p

All good then :)

@hugleo hugleo marked this pull request as draft October 15, 2023 13:56
@pazos
Copy link
Member

pazos commented Nov 8, 2023

@hugleo: I would like to merge this one, too. Please remove the draft flag :)

@hugleo
Copy link
Contributor Author

hugleo commented Nov 8, 2023

Can be merged. Unfortunately no official build support for lights at the moment :(
See : #436 for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants