Tolino Page 2 support #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand that this fixes your two concerns in #455 and you actually tested it using a self built apk. Is that ok? |
|
Yes that is correct. A self-built apk with those changes is currently running on my Tolino Page 2 and is working as expected with both those concerns resolved |
pazos
reviewed
Dec 27, 2023
pazos
reviewed
Dec 27, 2023
pazos
reviewed
Dec 27, 2023
|
I sorted it correctly now |
Remove unused imports: https://app.codacy.com/gh/koreader/android-luajit-launcher/pullRequest?prid=13309875 |
also done |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jan 13, 2024
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #455
This change is