CSS: adds support for 'orphans:' and 'widows:' properties #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glyph offset was applied twice. (cherry picked from commit b844a7af62d116d51757b55bf21b53dbfcc7a874)
This was referenced Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it was easy to do and fits well into the page splitting model.
Discussed in koreader/koreader#4484.
If we later decide the previous behaviour (of allowing widow and orphan lines) is to be enforced, we can just get it back by adding to epub.css:
* { orphans: 1 !important; widows: 1 !important;or* { orphans: inherit !important; widows: inherit !important; }Or we'll just have style tweaks to play with, and one with these to "Ignore publisher orphans and widows specifications".
Also includes Harfbuzz light fixe by @virxkane provided in #251 (comment)
(I also forgot to bump FORMATTING_VERSION_ID in the previous commits, so this one will do that with a bumpier bump of CACHE_FILE_FORMAT_VERSION.)