PageMap: allow building synthetic pages numbers #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a method (available to frontends) to build a synthetic page map, with a new page number every N chars. This could allow a frontend to show stable page numbers, that do not change with the rendering.
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method (available to frontends) to build a synthetic page map, with a new page number every N chars.
This could allow a frontend to show stable page numbers, that do not change with the rendering.
Initial idea described at koreader/koreader#9020 (comment).
This reuses what was added in #336 and koreader/koreader#6004.
The function to build it is just there, it works, takes a little bit of time to navigate all the text nodes (too complicated to do it as XML parsing time, and most people won't need it, so no need to force doing it here and waste space and memory - people who want it can bear the additional time it takes).
I'm still not sure how/if this could go into KOReader's menu and settings - but well, let's have this code available so the interested people can experiment.
This change is