Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various in-page footnotes, tables and covers fixes and tweaks #558

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Various in-page footnotes, tables and covers fixes and tweaks #558

merged 5 commits into from
Mar 20, 2024

Commits on Mar 20, 2024

  1. In-page footnotes: avoid with '-cr-hint: noteref-ignore' 

    This hint was initially added to prevent footnote popups
by frontend, and is rarely useful and used.
Have it also prevent in-page footnotes from being added
to the pages of links with that hint.
    @poire-z
    poire-z committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f8827a3 View commit details
    Browse the repository at this point in the history

  2. In-page footnotes: ensure they don't cross "flows" 

    When footnotes are pushed on a next page, make sure
this page ends up in the same "flow": if the next
content is part of another "flow", emit a page with
only these footnotes, and create a new page for the
coming content.
    @poire-z
    poire-z committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a509a93 View commit details
    Browse the repository at this point in the history

  3. Tables: fix rendering when negative text-indent 

    Tweak for table cells similar to how we do with negative
text-indent in normal paragraphs.
In getRenderedWidths(), try to properly size them when
overflow are not allowed ("book" render mode), although
this won't handle all cases.
    @poire-z
    poire-z committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7ed1c53 View commit details
    Browse the repository at this point in the history

  4. FB2 cover drawing: ensure _invertImages flag 

    FB2 cover drawing uses a specific codepath: update it
so it behaves as all other images drawing in regards
to the invertImage setting set on the main DrawBuf.
    @poire-z
    poire-z committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    738e7eb View commit details
    Browse the repository at this point in the history

  5. EPUB: fallback to look for a cover in the first fragment 

    If no EPUB3 or EPUB2 cover found, look at the first
XHTML fragment from the spine: if it contains a single
image and no text, assume that image can be used as
a cover.
Also relax these conditions if the image has alt"=cover":
it must just be before any text and other images.
    @poire-z
    poire-z committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    05b3c3d View commit details
    Browse the repository at this point in the history