EPUB: add identifiers to doc props #560
Conversation
change separator from ; to \n lvtinydom.h: move DOC_PROP_IDENTIFIERS below DOC_PROP_KEYWORDS epubfmt.cpp: fix styling of if/else
crengine/src/epubfmt.cpp
Outdated
| lString32 identifier; | ||
|
|
||
| // In version 3, scheme is not set but the type is rather included in the text itself |
There was a problem hiding this comment.
(You could remove this blank line, that doesn't really need to separate these 2 blocks.)
I'll merge it soon, and will bump it into koreader frontend with other fixes in the coming days.
Do you need/have some buddy changes to koreder-base/cre.cpp and/or frontend that should accompany this? Or is it all that is needed for your plugin ?
(Logically, for this to affect already opened book with a cache, we'd need to bump some version so all books are reparsed and get this new metadata in the cache. But if you're the only user of that for the coming days, no need to bump it and bother other users with a reload - so only you will need to rm cr3cache/* to get your books reparsed.)
(Unless I need to myself bump that version because of other changes, not sure yet if I'll have to.)
There was a problem hiding this comment.
I opened koreader/koreader-base#1758 and koreader/koreader#11628
I wanted to write a plugin to automatically sync my progress from KOReader to hardcover.app and need the ISBN of the book for that to ensure proper matching.
This will add the identifiers as
doc_propin the format ofscheme:identifierseparated by;e.g.isbn:9783462312317;asin:b0ckwvvv4zThis change is