Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FB2 image sizing & centering, and bottom border on empty block elements #563

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Fix FB2 image sizing & centering, and bottom border on empty block elements #563

merged 3 commits into from
Apr 7, 2024

Commits on Apr 6, 2024

  1. EPUB: avoid crash when '@font-face' in <head><style> 

    Assertions in LVFontCache::_removeDocumentFonts() would fail
(when DEBUG enabled).
    @poire-z
    poire-z committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    805d81f View commit details
    Browse the repository at this point in the history

  2. FB2: fix block images sizing and centering 

    Followup to 1544bcf, where we made an image self
container's width adjust to the image width, so
text-align:center no longer does what was expected.
Switch to margin-left/right:auto to get them centered
again.
Also, for standalone block images, set the strut and
line-height to 0 (as we do for HTML) so they their
block is adjusted to the page height when the image
itself exceeds it, to avoid such images to be
truncated and sliced on two pages.
    @poire-z
    poire-z committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d469daa View commit details
    Browse the repository at this point in the history

  3. lvrend: fix positioning of bottom border on empty block elements 

    Fix some possible issues with empty block elements having
some bottom border (included in padding_bottom) when
previous vertical margins are collapsing.
(Not 100% certain this is the right fix that won't
cause side effects...)
    @poire-z
    poire-z committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f4370bc View commit details
    Browse the repository at this point in the history