This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
add css menu and embedded css toggle #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* now css argument is removed from newDocView call. * when setStyleSheet method cannot read given css file, it clears all the applied style. * add setEmbeddedStyleSheet method.
|
Thank you, I will test it today. |
|
Trying to open an fb2 file results in: But maybe this is because I have history files from the pre-PR state. I'll remove them and will try again. |
|
One bug: invoking css selection menu via |
|
Oh, I put the redraw current page in the wrong place ;p |
|
BTW, did you still have the history file that crashes the reader? I am curious about the cause of the crash. |
|
No, I didn't save those history files unfortunately. |
tigran123
added a commit
that referenced
this pull request
Jan 22, 2013
add css menu and embedded css toggle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, only embedded css is loaded by default. I am not sure whether crengine is designed to load
format.cssby default, so we need further testing on this change.