Skip to content

Commit

Permalink
More comments on the REAGL behavior on Mk. 7
Browse files Browse the repository at this point in the history
This matters mainly for stuff calling a TextViewer inside the UI, since
those use partial ;).
  • Loading branch information
NiLuJe committed Jan 6, 2021
1 parent e7e8b58 commit 926c294
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ffi/framebuffer_mxcfb.lua
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,10 @@ function framebuffer:init()
-- We handle that by NOT setting waveform_reagl (so _isREAGLWaveFormMode never matches), and just customizing waveform_partial.
-- Nickel doesn't wait for completion of previous markers on those PARTIAL GLR16, so that's enough to keep our heuristics intact,
-- while still doing the right thing everywhere ;).
-- Turns out there's a good reason for that: the EPDC will fence REAGL updates internally (possibly via the PxP).
-- This makes interaction between partial and other modes slightly finicky in practice in some corner-cases,
-- (c.f., the SkimTo widget workaround were we batch a button highlight with the reader's partial,
-- and then fence *that* manually to avoid the partial being delayed by the button's 'fast' highlight).
if isMk7 then
self.device.canHWDither = yes
self.mech_refresh = refresh_kobo_mk7
Expand Down

0 comments on commit 926c294

Please sign in to comment.