Skip to content

Commit

Permalink
Fix eggregious ghosting on older Kindles (#803)
Browse files Browse the repository at this point in the history
* Switch from A2 to DU on older Kindles, too.

A2 is basically terrible on the Touch, for some mysterious reason.
I may have been testing on a K4 or a K3 at the time, because I'd have
noticed otherwise...

(We've always used A2 for "fast" on Kindle, but we used to use "fast"
*very* sparingly before I changed that).

* Re-order that test to abort early on !KINDLE
  • Loading branch information
NiLuJe committed Feb 6, 2019
1 parent cece8f7 commit afd0c6c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ffi/framebuffer_mxcfb.lua
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,9 @@ local function mxc_update(fb, update_ioctl, refarea, refresh_type, waveform_mode
-- (we might actually want the one before that), but in the vast majority of cases, that's good enough,
-- and saves us a lot of annoying and hard-to-get-right heuristics anyway ;).
-- Make sure it's a valid marker, to avoid doing something stupid on our first update.
if (refresh_type == C.UPDATE_MODE_FULL
if fb.mech_wait_update_submission
and (refresh_type == C.UPDATE_MODE_FULL
or fb:_isUIWaveFormMode(waveform_mode))
and fb.mech_wait_update_submission
and (marker >= MARKER_MIN and marker <= MARKER_MAX) then
fb.debug("refresh: wait for submission of (previous) marker", marker)
fb.mech_wait_update_submission(fb, marker)
Expand Down Expand Up @@ -530,6 +530,7 @@ function framebuffer:init()
self.waveform_reagl = C.WAVEFORM_MODE_REAGL
self.waveform_partial = self.waveform_reagl
else
self.waveform_fast = C.WAVEFORM_MODE_DU -- NOTE: DU, because A2 looks terrible on the Touch, and ghosts horribly. Framework is actually using AUTO for UI feedback inverts.
self.waveform_partial = C.WAVEFORM_MODE_GL16_FAST -- NOTE: Depending on FW, might instead be AUTO w/ hist_gray_waveform_mode set to GL16_FAST
end
Expand Down

0 comments on commit afd0c6c

Please sign in to comment.