Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SDL 1.2 #828

Closed
Frenzie opened this issue Feb 21, 2019 · 0 comments · Fixed by #963
Closed

Deprecate SDL 1.2 #828

Frenzie opened this issue Feb 21, 2019 · 0 comments · Fixed by #963

Comments

@Frenzie
Copy link
Member

Frenzie commented Feb 21, 2019

SDL 1.2 has been deprecated since 2014 or so.

https://wiki.libsdl.org/Support

SDL 1.2 is deprecated and not recommended for new projects.

Qemu recently followed suit: https://patchwork.kernel.org/patch/10164537/

I haven't actually tested it in years, so the status of SDL 1.2 in KOReader is that it may not be broken.

I think that other than the base CI, nothing really uses it anymore.

- libsdl1.2-dev

I briefly entertained the idea of testing both SDL 1.2 as well as SDL 2 (cf. koreader/koreader#4631 (comment)) but the additional maintenance burden isn't worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant