Switch to custom PB TC #1048
Merged
Switch to custom PB TC #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: I'm not quite sure why the glib shared library is shipped on PB? I think/hope that we're linking sdcv statically... (We might not have historically always been, since Kindle ships a glib). |
Frenzie
reviewed
Feb 13, 2020
|
(Rebased without #1047) |
We always link sdcv dynamically against it anyway. Relying on the platform's own was potentially a terrible idea.
Because we have to pull in the system's libstdc++ through inkview, so we can't blindly ignore the potential issue. Which still exists, because FW 5.19+ is using GCC 6.3.0's libstdc++... -_-". c.f., https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html
It'd been a while since I'd actually re-read the docs. It's my understanding that the potential for actual runtime issues should be low to nonexistent, even if we were mixing ABIs.
InkView is doing... Works around koreader/koreader#5861
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Feb 17, 2020
• Workaround mysterous xtext/hb crner-cases on armv6 (koreader/koreader-base#1046) • Use the C BB on every !Android eInk device (koreader/koreader-base#1047) • Switch to our own custom PB TC (koreader/koreader-base#1048) • tabs/tabstop handling in xtext (koreader/koreader-base#1049)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Feb 17, 2020
• Workaround mysterous xtext/hb crner-cases on armv6 (koreader/koreader-base#1046) • Use the C BB on every !Android eInk device (koreader/koreader-base#1047) • Switch to our own custom PB TC (koreader/koreader-base#1048) • tabs/tabstop handling in xtext (koreader/koreader-base#1049)
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Feb 18, 2020
• Workaround mysterous xtext/hb crner-cases on armv6 (koreader/koreader-base#1046) • Use the C BB on every !Android eInk device (koreader/koreader-base#1047) • Switch to our own custom PB TC (koreader/koreader-base#1048) • tabs/tabstop handling in xtext (koreader/koreader-base#1049) * Pickup koreader/koreader-base#1050
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
• Workaround mysterous xtext/hb crner-cases on armv6 (koreader/koreader-base#1046) • Use the C BB on every !Android eInk device (koreader/koreader-base#1047) • Switch to our own custom PB TC (koreader/koreader-base#1048) • tabs/tabstop handling in xtext (koreader/koreader-base#1049) * Pickup koreader/koreader-base#1050
NiLuJe
added a commit
to NiLuJe/koreader-base
that referenced
this pull request
Apr 4, 2020
High kablooey potential, because we pull liblipc, which depends on it and libgthread, so we'd be mixing glib versions between the two... Regression since koreader#1048
NiLuJe
added a commit
that referenced
this pull request
Apr 5, 2020
* Ditch thread-safety in HB on LEGACY & PB to avoid weird atomics issues on armv6 koreader/koreader#6024 koreader/koreader#5780 * Don't ship glib on Kindle High kablooey potential, because we pull liblipc, which depends on it and libgthread, so we'd be mixing glib versions between the two... Regression since #1048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. koreader/koxtoolchain#22
Got rid of all the GCC 4.8 patches.
Got rid of the dedicated toolchain target.
Stopped flagging PB as LEGACY (??!!), because that made no sense in the first place anyway.
Will probably need a rebase because I caught #1047 while working on this, so it's currently in here too ;).
This change is