Tell SDL2 to handle HiDPI shenanigans for us #1056
Conversation
Makes the emulator behave properly on macOS Retina screens, at least. Contributed by @magicmirror1365 in koreader/koreader#5909, thanks!
| @@ -220,6 +220,7 @@ cdecl_const(SDL_WINDOWPOS_UNDEFINED) | |||
| cdecl_const(SDL_WINDOW_FULLSCREEN) | |||
| cdecl_const(SDL_WINDOW_FULLSCREEN_DESKTOP) | |||
| cdecl_const(SDL_WINDOW_RESIZABLE) | |||
| cdecl_const(SDL_WINDOW_ALLOW_HIGHDPI) | |||
There was a problem hiding this comment.
Btw, do you want to put it in alphabetically? (Three lines up.)
There was a problem hiding this comment.
I'd actually prefer it in increasing value order (i.e., the same order as the header), which I'm not sure is actually the case either :D.
There was a problem hiding this comment.
That's an interesting point. RESIZABLE should go in between FULLSCREEN and FULLSCREEN_DESKTOP then. ;-)
There was a problem hiding this comment.
Fwiw I think they should go in value order too
will be ignored, so, make this unconditional.
Follow their original order (i.e., increasing values).
|
Sidebar, GH Actions is running the build here but for some reason it's not showing it in the PR. |
|
Sidebar: this made me realize that the LuaJIT bitops module accepts > 2 args for the bitops. I'm fairly sure I've left a mess of ugly nested bit.op() stuff in the blitbuffer code that could be cleaned up this way ;p. |
|
Haha, awesome. 👍 |
* Tell SDL2 to handle HiDPI shenanigans for us koreader/koreader-base#1056 * [CI] Run action on PR koreader/koreader-base#1058 * thirdparty/fribidi 1.0.9 koreader/koreader-base#1057
* Tell SDL2 to handle HiDPI shenanigans for us koreader/koreader-base#1056 * [CI] Run action on PR koreader/koreader-base#1058 * thirdparty/fribidi 1.0.9 koreader/koreader-base#1057
* Tell SDL2 to handle HiDPI shenanigans for us koreader/koreader-base#1056 * [CI] Run action on PR koreader/koreader-base#1058 * thirdparty/fribidi 1.0.9 koreader/koreader-base#1057
Makes the emulator behave properly on macOS Retina screens, at least.
Contributed by @magicmirror1365 in
koreader/koreader#5909, thanks!
This change is