Tweak RTC alarm disable #1106
Merged
Tweak RTC alarm disable #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do it like busybox & Nickel The other approach would be a WKALM_RD + WKALM_SET. I'm not *quite* sure what the previous behavior was actually doing (No idea what an epoch set to -1 actually does in practice?)
|
Not that anything was ever actually calling |
Frenzie
approved these changes
May 30, 2020
Must've done something. :-P Might just be a shortcut to get something prior to the current time. |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
May 31, 2020
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
May 31, 2020
* Disable the RTC alarm on shutdown * Nice typo. * Bump base koreader/koreader-base#1103 koreader/koreader-base#1105 koreader/koreader-base#1106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do it like busybox & Nickel
The other approach would be a WKALM_RD + WKALM_SET.
I'm not quite sure what the previous behavior was actually doing
(No idea what an epoch set to -1 actually does in practice?)
This change is