Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zsync2 #1108

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Update zsync2 #1108

merged 1 commit into from
Jun 2, 2020

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Jun 2, 2020

Resync w/ upstream
Properly handle filesystems that don't support hard-links, like legacy
zsync used to.


This change is Reviewable

Resync w/ upstream
Properly handle filesystems that don't support hard-links, like legacy
zsync used to.
@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 2, 2020

This ought to fix https://www.mobileread.com/forums/showthread.php?t=330375

(or at the very least no longer print the warning on link, because it'll always fail w/ EPERM on vfat, and if issue there is, print the strerror, too).

(That codepath is only triggered if a previous incomplete download is found. Logic seemed dodgy, so I basically replaced it with the original legacy one, which does make sense.
And restore the original comments to explain it, because, admittedly, not everybody remembers how and why link() fails on vfat ;)).

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 2, 2020

Actual changeset: NiLuJe/zsync2@7565c08...e618d18

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks!

@NiLuJe NiLuJe merged commit 4d8b840 into koreader:master Jun 2, 2020
Frenzie added a commit to Frenzie/koreader that referenced this pull request Jun 4, 2020
Cf. <koreader#6228>

Includes:
* Update to OpenSSH 8.3p1 koreader/koreader-base#1107
* Update zsync2 koreader/koreader-base#1108
* thirdparty/harfbuzz 2.6.7 koreader/koreader-base#1109
* Add thirdparty/lua-htmlparser for newsdownloader koreader/koreader-base#1110
Frenzie added a commit to koreader/koreader that referenced this pull request Jun 4, 2020
Cf. <#6228>

Includes:
* Update to OpenSSH 8.3p1 koreader/koreader-base#1107
* Update zsync2 koreader/koreader-base#1108
* thirdparty/harfbuzz 2.6.7 koreader/koreader-base#1109
* Add thirdparty/lua-htmlparser for newsdownloader koreader/koreader-base#1110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants