Minor lua-rapidjson cleanups #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maaaaaaybe some relevant ARM changes.
Frenzie
reviewed
Jun 9, 2020
There was a problem hiding this comment.
I was wondering what you meant by upstream but I guess that's https://github.com/Tencent/rapidjson
Might be worth tossing that in a PR over at lua-rapidjson real quick? If it's merged as quickly as the other PR we can forgo on a giant patch. ;-) (I can create the PR later if you want.)
|
c.f., https://status.fedoraproject.org/ as for why the downloads are broken ;). |
|
I opened a PR over at xpol/lua-rapidjson#49. |
|
Alright, you can drop the one patch. ;-) |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jun 12, 2020
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Jun 12, 2020
* floor most every dimension computations involving MUL or DIV Should avoid passing nonsensical floating point coordinates/dimensions to the UI code. * Update base * koreader/koreader-base#1113 * koreader/koreader-base#1114 * koreader/koreader-base#1115 * Bump android-luajit-launcher koreader/android-luajit-launcher#230 koreader/android-luajit-launcher#231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cosmetic tweak that I missed yesterday.
And bump the actual rapidjson code, there might be some relevant arm changes upstream....
This change is