remarkable: fix button-listen when resuming from suspend #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the home button is used to wake the device from suspend the evdev events have surprising time stamps. There is a pair of press & release events, but the press has a timestamp from when the device went into suspend and the release has a timestamp from after. This means that the wake keypress will launch koreader as button-listen thinks the key was held down for the whole time the device was suspended! Instead, just record CLOCK_BOOTTIME timestamps for the events and use those instead of the event timestamps. CLOCK_BOOTTIME is monotonic but includes time spend in suspend. Also keep track of whether button-listen saw a key press before each key release. Probably not strictly required but seemed sensible to add.
|
Fixes koreader/koreader#6029 |
Frenzie
approved these changes
Jul 19, 2020
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Jul 19, 2020
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the home button is used to wake the device from suspend the evdev
events have surprising time stamps. There is a pair of press & release
events, but the press has a timestamp from when the device went into
suspend and the release has a timestamp from after. This means that the
wake keypress will launch koreader as button-listen thinks the key was
held down for the whole time the device was suspended!
Instead, just record CLOCK_BOOTTIME timestamps for the events and use
those instead of the event timestamps. CLOCK_BOOTTIME is monotonic but
includes time spend in suspend.
Also keep track of whether button-listen saw a key press before each key
release. Probably not strictly required but seemed sensible to add.
This change is