Minor third-party bumps #1162
Merged
Minor third-party bumps #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Aug 19, 2020
thirdparty/sqlite/CMakeLists.txt
Outdated
| ExternalProject_Add( | ||
| ${PROJECT_NAME} | ||
| DOWNLOAD_DIR ${KO_DOWNLOAD_DIR} | ||
| URL https://www.sqlite.org/2020/sqlite-autoconf-${SQLITE_VER}.tar.gz | ||
| URL_HASH SHA1=ea14ef2dc4cc7fcbc5ebbb018d3a03faa3a41cb4 | ||
| URL_HASH SHA3=6e94e9453cedf8f2023e3923f856741d1e28a2271e9f93d24d95fa48870edaad |
There was a problem hiding this comment.
It's not happy about it. ;-)
CMake Error at /usr/share/cmake-3.5/Modules/ExternalProject.cmake:1850 (message):
URL_HASH is set to
SHA3=6e94e9453cedf8f2023e3923f856741d1e28a2271e9f93d24d95fa48870edaad
but must be ALGO=value where ALGO is
MD5|SHA1|SHA224|SHA256|SHA384|SHA512
and value is a hex string.
Call Stack (most recent call first):
/usr/share/cmake-3.5/Modules/ExternalProject.cmake:2459 (_ep_add_download_command)
CMakeLists.txt:37 (ExternalProject_Add)
|
Might work in newer Cmake, dunno if the time is quite right to bump it.
Need to check what fdroid uses.
…On Wed, Aug 19, 2020, 11:56 NiLuJe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In thirdparty/sqlite/CMakeLists.txt
<#1162 (comment)>
:
> ExternalProject_Add(
${PROJECT_NAME}
DOWNLOAD_DIR ${KO_DOWNLOAD_DIR}
URL https://www.sqlite.org/2020/sqlite-autoconf-${SQLITE_VER}.tar.gz
- URL_HASH SHA1=ea14ef2dc4cc7fcbc5ebbb018d3a03faa3a41cb4
+ URL_HASH SHA3=6e94e9453cedf8f2023e3923f856741d1e28a2271e9f93d24d95fa48870edaad
*sadface*
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRQBL42TLKGON35HOINOTSBOOUPANCNFSM4QEJOI5A>
.
|
It does ;) (After jumping down the rabbit hole that is CMake's doc... https://cmake.org/cmake/help/latest/command/string.html#supported-hash-algorithms) |
Switch to manual MD5 checksums because upstream moved to SHA3 and CMake is terrible.
|
Assuming the docs are correct it looks like it should be supported in 3.8 and up. |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Aug 24, 2020
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Aug 25, 2020
* \o/ * Make sure the (debug) event log doesn't end up in the fd table of our child processes... Otherwise, it breaks USBMS. * Close suspicious fds in the Wi-Fi scripts To prevent any and all issues w/ USBMS down the road... * Minor USBMS UI tweaks * Always ask for confirmation to start on USBMS session on plug * Bump base koreader/koreader-base#1161 koreader/koreader-base#1162 koreader/koreader-base#1163 koreader/koreader-base#1165 koreader/koreader-base#1167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is