Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harfbuzz FFI #1211

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Add harfbuzz FFI #1211

merged 4 commits into from
Oct 8, 2020

Conversation

ezdiy
Copy link
Member

@ezdiy ezdiy commented Oct 8, 2020

Full binding, so as to avoid type dep annoyances in the future.
Primarily for mupdf font queries, but perhaps also more generally,
cf koreader/koreader#6763


This change is Reviewable

Full binding, so as to avoid type dep annoynances in the future.
Primarily for mupdf font queries, but perhaps also more generally
cf koreader/koreader#6763
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, we probably don't really need the whole shebang from the get-go though?

@ezdiy ezdiy merged commit 535bc4c into koreader:master Oct 8, 2020
@ezdiy
Copy link
Member Author

ezdiy commented Oct 8, 2020

@Frenzie Almost-automated fire and forget thing via bunch of :%s macros.

@NiLuJe was wondering the same after I spammed inkview the same way. Indeed there's no need for full cdecl, but figuring what to cherry pick while you're prototyping splits loyalties, as you need to regenerate the header repeatedly and deal with the cascades of type dependencies. Albeit I a admit it's a little bit bloaty (5kb vs 50k lua file), perf wise the impact is not measurable.

@NiLuJe
Copy link
Member

NiLuJe commented Oct 8, 2020

It's fine by me if there's no perf impact ;).

I tend to like hand-tailored cdecls because it serves as a bit of documentation in the sense of: "hey, here are the things I'll probably be using", but it's more of a personal choice than anything, really ;).

@Frenzie
Copy link
Member

Frenzie commented Oct 8, 2020

That's why I like it too, I think it makes it easier to grok what's going on. Besides that it's irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants