Fiddle with CBB toggling to try to avoid weird Android corner-cases #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not that it changes much in practice, apparently.
Most notably, allowing to disable it on startup in reader.lua, without having to do an extra jit.flush, because it has a tendency to make the already complicated mcode allocation situation worse on that platform.
This was referenced Dec 22, 2020
Frenzie
reviewed
Dec 22, 2020
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 23, 2020
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Dec 23, 2020
* When the CBB is disabled, attempt to apply the JIT tweaks earlier, avoiding the JIT code flush in the process * Drop debug prints * Bump base koreader/koreader-base#1263 koreader/koreader-base#1264
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
…oreader#1263) * Handle inversion in BB4:fill Not that it changes much in practice, apparently. * Rejig the CBB toggle to allow greater flexibility in front Most notably, allowing to disable it on startup in reader.lua, without having to do an extra jit.flush, because it has a tendency to make the already complicated mcode allocation situation worse on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mildly related to part of the recent Android discussions on Gitter ;).
This change is