Android: Never ever touch the Lua blitter #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fun fact: remember the days when the one (nearly) sure-fire way we could reproduce the same kind of weird JIT hiccups on Kobo @ 16bpp back in the day, @poire-z? That was with AlphaContainer & MovableContainer... And what do they have to do with this? They're the main source of |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 24, 2020
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Dec 24, 2020
* Bump android-luajit-launcher koreader/android-luajit-launcher#279 * Bump base koreader/koreader-base#1265 koreader/koreader-base#1267 koreader/koreader-base#1268
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
* Go through the C BB for nightmode on Android, to avoid performance issues in the Lua blitter because of the mcode alloc restrictions on that platform. (Re koreader#1200) * Port paintRoundedCorner to the C blitter to avoid the setPixel invert/cbb/android exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side-effect of #1200, software nightmode was no-longer handled in the C blitter, it instead went through to the Lua blitter.
This exacerbated the latent issues with LuaJIT and mcode_alloc on that platform (remember, the C blitter was initially implemented specifically to avoid stressing LuaJIT with the blitter code on Android because of that fact).
So, without going back to the admittedly messy way this was handled before, tweak a few things to make Android a special snowflake again, so that nightmode on Android no longer goes through the Lua blitter.
In fact, port
paintRoundedRectto the C blitter to make doubly sure of that (and get rid of an ugly hack that was necessary to handle inversion quirks in setPixel otherwise ;p).This change is