Minor cosmetic tweak #1280
Merged
Minor cosmetic tweak #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
approved these changes
Jan 3, 2021
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jan 8, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Jan 10, 2021
* Wherever possible, do an actual dumb invert on the Screen BB instead of repainting the widget, *then* inverting it (which is what the "invert" flag does). * Instead of playing with nextTick/tickAfterNext delays, explicitly fence stuff with forceRePaint * And, in the few cases where said Mk. 7 quirk kicks in, make the fences more marked by using a well-placed WAIT_FOR_UPDATE_COMPLETE * Fix an issue in Button where show/hide & enable/disable where actually all toggles, which meant that duplicate calls or timing issues would do the wrong thing. (This broke dimming some icons, and mistakenly dropped the background from FM chevrons, for example). * Speaking of, fix Button's hide/show to actually restore the background properly (there was a stupid typo in the variable name) * Still in Button, fix the insanity of the double repaint on rounded buttons. Turns out it made sense, after all (and was related to said missing background, and bad interaction with invert & text with no background). * KeyValuePage suffered from a similar issue with broken highlights (all black) because of missing backgrounds. * In ConfigDialog, only instanciate IconButtons once (because every tab switch causes a full instantiation; and the initial display implies a full instanciation and an initial tab switch). Otherwise, both instances linger, and catch taps, and as such, double highlights. * ConfigDialog: Restore the "don't repaint ReaderUI" when switching between similarly sized tabs (re #6131). I never could reproduce that on eInk, and I can't now on the emulator, so I'm assuming @poire-z fixed it during the swap to SVG icons. * KeyValuePage: Only instanciate Buttons once (again, this is a widget that goes through a full init every page). Again, caused highlight/dimming issues because buttons were stacked. * Menu: Ditto. * TouchMenu: Now home of the gnarliest unhilight heuristics, because of the sheer amount of different things that can happen (and/or thanks to stuff not flagged covers_fullscreen properly ;p). * Bump base koreader/koreader-base#1280 koreader/koreader-base#1282 koreader/koreader-base#1283 koreader/koreader-base#1284 * Bump android-luajit-launcher koreader/android-luajit-launcher#284 koreader/android-luajit-launcher#285 koreader/android-luajit-launcher#286 koreader/android-luajit-launcher#287
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely random whitespace change while looking into https://www.mobileread.com/forums/showpost.php?p=4077126&postcount=334 (which, btw, makes no sense, unless there's some heinous viewport/rotation shenanigan going on. My one theory was an underflow, but 2020.12 wasn't using unsigned data types yet, and checkBounds should guard against negative values anyway; and 2020.12 was effectively using the Lua blitter for nightmode, so that magically working now makes no sense, again).
(Well, not so random,
getPhysicalRectjust below it is formatted the same way).This change is