Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure nnsvg links against libm in every circumstances #1292

Merged
merged 2 commits into from Jan 23, 2021

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Jan 23, 2021

  • Link flags on the left of -o: deprecated. May apparently eat your firstborn's soul and/or said link flags ^^.
  • Linking order: stuff that requires symbols on the left of stuff that provides those symbols. (And LuaJIT requires libm ;)).

Re koreader/koreader#7190


This change is Reviewable

deprecated

And apparently leads to unpredictable results in some cases.

Fix #7190
Stuff that *requires* symbols should be on the *left* of stuff that
*provides* said symbols.

This is only critical when static linking, though.

(c.f.,
https://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking).
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but did you test or should I?

@NiLuJe
Copy link
Member Author

NiLuJe commented Jan 23, 2021

Haven't tested on affected systems (because I don't have any of those ;p), no, so, be my guest ;).

@Frenzie
Copy link
Member

Frenzie commented Jan 23, 2021

Well, I imagine using a pre ~Ubuntu 20.04 to build the whole thing and testing on something newer is part of it, anyway. I'll give it a quick build on my desktop (or not that quick since I haven't built non-debug in quite a while…)

@Frenzie
Copy link
Member

Frenzie commented Jan 23, 2021

Drat, I forgot about this:

cd koreader-appimage-x86_64-linux-gnu && pwd && \
	rm -rf tmp && mkdir -p tmp && \
	cp -Lr koreader tmp && \
	rm -rf tmp/koreader/ota && \
	rm -rf tmp/koreader/resources/icons/src && \
	rm -rf tmp/koreader/spec
/home/frans/src/kobo/koreader/koreader-appimage-x86_64-linux-gnu
cp: cannot stat 'koreader/libs/libbsd.so.0': No such file or directory

Meh, let's just bump it and see what happens. I don't feel like dragging out the ole' Docker image tonight. xP

@Frenzie Frenzie merged commit 1bc1c39 into koreader:master Jan 23, 2021
Frenzie added a commit to Frenzie/koreader that referenced this pull request Jan 23, 2021
Frenzie added a commit to koreader/koreader that referenced this pull request Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants