Kobo Libra: Bypass WAIT_FOR_UPDATE_COMPLETE ioctls... #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can apparently mysteriously timeout for no apparent reason, which obviously murders performance. This a very, very shitty hack, hopefully until more is understood about the issue... Re koreader/koreader#7340
Frenzie
reviewed
Mar 14, 2021
| -- This is roughly five times the amount of time a real *NOP* WAIT_FOR_UPDATE_COMPLETE would take. | ||
| -- An effective one could block for ~150ms to north of 500ms, depending on the waveform mode of the waited on marker. | ||
| local function stub_mxc_wait_for_update_complete() | ||
| return ffiUtil.usleep(1000) |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Mar 15, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Mar 15, 2021
This was referenced Mar 19, 2021
NiLuJe
added a commit
that referenced
this pull request
Mar 21, 2021
Whether a device capcheck enables it by default or not. (Followup to #1329). Also, actually *log* failures for this ioctl in debug mode, which should help diagnosing affected devices.
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
They can apparently mysteriously timeout for no apparent reason, which obviously murders performance. This a very, very shitty hack, hopefully temporary until more is understood about the issue... Re: koreader/koreader#7340
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
Whether a device capcheck enables it by default or not. (Followup to koreader#1329). Also, actually *log* failures for this ioctl in debug mode, which should help diagnosing affected devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can apparently mysteriously timeout for no apparent reason, which
obviously murders performance.
This a very, very shitty hack, hopefully only there until more is understood about
the issue...
Re: koreader/koreader#7340
This change is