MXCFB: Move cap checks to front #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move everything to Device capChecks in front.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Mar 26, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Mar 26, 2021
* Move MXCFB capchecks to front The fact that this was halfway in front/halfway in base was weird and mistake-prone (c.f., the amount of times I forgot to update one bit or the other). * Initial KOA3 support Assume it's essentially a KOA2. Meaning no warmth handling for now. * Bump base koreader/koreader-base#1339 koreader/koreader-base#1338
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
* Get rid of the weird device detection code at framebuffer_mxcfb init Move everything to Device capChecks in front.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes adding support for new devices less unwieldy and error-prone.
This change is