Completely random table alloc tweaks in Lua/C modules #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(usleep is deprecated, and is in fact a wrapper around nanosleep on conforming glibcs).
Not so much for the performance diff (which is likely to be minimal, although we do know that ther'es no metamethod), but for consistency with the previous fields.
LuaJIT types them correctly internally on arm
Will need testing :/.
This reverts commit 2b37298.
I mean, good luck finding a book with > 20 levels of ToC depth, but that could theoretically happen and blow the Lua stack.
NiLuJe
commented
Apr 8, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
NiLuJe
commented
Apr 8, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status:
poire-z
approved these changes
Apr 8, 2021
|
I've spent a bit of time doing weird things in the emu without breaking anything so far ;). The wonkiest shit was very much in djvu, though, so I have no specific worries about xtext/cre. |
Frenzie
approved these changes
Apr 9, 2021
We're clearing the stack, so, actually use that fact to simplify this ;). (Because clearing the stack is otherwise entirely pedantic: what's returned is always the uppermost n elements in the stack).
lua_objlen returns a size_t, and lua_tointeger a lua_Integer (usually a ptrdiff_t).
NiLuJe
commented
Apr 9, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4.
Reviewable status:
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Apr 9, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Apr 10, 2021
* Bump android-laujit-launcher koreader/android-luajit-launcher#297 * Bump base koreader/koreader-base#1351 koreader/koreader-base#1350 koreader/koreader-base#1349 koreader/koreader-base#1348
roygbyte
pushed a commit
to roygbyte/koreader-base
that referenced
this pull request
Mar 3, 2022
Mainly pre-alloc when we can know/estimate the amount of elements, unify usage of *raw* setters for metatable-less tables, and stricter typing (e.g., don't cast integers to double by limiting usage of `pushnumber` to actual floats). Also added some comments for the twistiest bits of logic (djvu, lookin' at ya').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly pre-alloc when we can know/estimate the amount of elements, unify usage of raw setters for metatable-less tables, and stricter typing (e.g., don't cast integers to double by limiting usage of
pushnumberto actual floats).Also added some comments for the twistiest bits of logic (djvu, lookin' at ya').
This change is