Cache/MµPDF shenanigans, the base edition #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around numerous issues (leak, corruption) occuring on overcommit on the old version we're currently using.
We've stopped using in front, in favor of our own Persist and its bitser or LuaJIT backends. (We still keep the buildsystem around, as we currently pickup its luacompat52 build on Android for the Evernote plugin. Which also builds/ships its own copy of it).
Make it return the number of words, too. Helps cache size estimations in front.
Frenzie
reviewed
May 4, 2021
There was a problem hiding this comment.
The commit title me think you randomly included a fix for koreader/koreader#7631
|
Not that I know of, unless the two are related, which I doubt, but koreader/koreader#7627, yeah ;). |
|
Yeah, no, the commit titled |
NiLuJe
commented
May 5, 2021
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
May 5, 2021
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
May 5, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bits and bobs needed by koreader/koreader#7624 related to koreader/koreader#7627
This change is