New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update to Ubuntu 18.04 Docker images #1375
[CI] Update to Ubuntu 18.04 Docker images #1375
Conversation
@pazos Actually, do you know which CMake F-Droid uses? I just realized the second commit may be a bit overenthusiastic. |
@Frenzie: https://packages.debian.org/stretch/cmake (3.7.2) There's also a backport: https://packages.debian.org/stretch-backports/devel/cmake (3.16.3) that should be available to install via sudo apt-get in https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/org.koreader.launcher.yml#L21 |
Thanks. Well, I'll just revert that second commit. I don't think CMake <3.11 really gives us much extra anyway, although I do vaguely seem to recall @NiLuJe complaining about CMake <3.7 recently? |
Whatever passes as "modern" CMake would be great^Wless terrible ;). |
CMake 3+ and especially 3.4+ is called "modern" CMake afaik. :-P |
As a point of reference, I can't even install anything older than 3.13 over here ;p. |
@NiLuJe Sidenote, are you familiar with this argument
|
@Frenzie: That doesn't ring a bell, no. Hard to say what's happening without a verbose build to see the crazy libtool command line ;). |
The Android image issue should be resolved in koreader/virdevenv#65. I hadn't realized it was pulling in openjdk-11 (and was therefore defaulting to it). tl;dr Should be almost done. |
This reverts commit fc43cf7.
Cf. koreader/koreader-base#1375 (no dependency).
Well missed the chance to request cmake 3.11..next time.. |
Just state your reasons. |
Well FetchContent and optimisations :) |
Could you please be a lot more concrete? |
Cmake 3.13 has Quality of life changes...https://cmake.org/cmake/help/latest/release/3.13.html#id8 Maybe better… |
But what do you want to do with FetchContent? How is DownloadProject insufficient? Which specific optimizations would be made possible? |
It ensures no duplicating of dependencies thoughout the project tree.. |
Which duplication are you referring to? |
Of source files ,no double downloads |
Which double downloads are you referring to? |
No specific examples... I guess our big tree can can be help by caching deps that may be used in many subprojects |
Cf. koreader/koreader-base#1375 (no dependency).
Cf. koreader/koreader-base#1375 (no dependency).
Cf. koreader/koreader-base#1375 (no dependency).
See koreader/virdevenv#57 and koreader/virdevenv#62
This change is