Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More djvulibre CMake tweaks... #1410

Merged
merged 2 commits into from
Sep 12, 2021
Merged

More djvulibre CMake tweaks... #1410

merged 2 commits into from
Sep 12, 2021

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 12, 2021

Re #1409

Let's see if this still builds...


This change is Reviewable

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably more robust.

@NiLuJe
Copy link
Member Author

NiLuJe commented Sep 12, 2021

And it makes for slightly less confusing output in case one of 'em implodes ;).

@Frenzie
Copy link
Member

Frenzie commented Sep 12, 2021

Definitely, yes.

@NiLuJe NiLuJe merged commit e820726 into koreader:master Sep 12, 2021
@poire-z
Copy link
Contributor

poire-z commented Sep 16, 2021

Random PR hijack.
Dunno if we're in any way impacted by this, so, just mentionning it:
https://news.slashdot.org/story/21/09/15/2034224/travis-ci-flaw-exposed-secrets-of-thousands-of-open-source-projects

@Frenzie
Copy link
Member

Frenzie commented Sep 16, 2021

We haven't had any Travis builds for weeks if not months, so definitely not that particular one. Besides that, I think I already deleted any remaining push tokens for Travis a few years ago.

NiLuJe added a commit to koreader/koreader that referenced this pull request Sep 25, 2021
roygbyte pushed a commit to roygbyte/koreader-base that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants