A few quick blitbuffer fixes #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source BB types. That means ignoring the rotation flag in *every* case, and documenting that fact. Avoids crashes on rotated buffers of common types, where the stride member matches the unrotated layout, while the getWidth & getHeight methods did not.
poire-z
approved these changes
Dec 11, 2021
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 12, 2021
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Dec 13, 2021
* TileCache: Preserve BlitBuffer's inversion & rotation This somehow fell through the cracks for all these years ;). (We can't simply save the config field directly, because bb.fromstring always generates an allocated bb, which may not be the case of the source bb). * Bump base koreader/koreader-base#1440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at the tail end of koreader/koreader#3905 ;).
This change is