Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update all but Android to new CMake 3.16 image #1487

Merged
merged 4 commits into from
Apr 2, 2023
Merged

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Jun 3, 2022

See koreader/virdevenv#80

For #1486

Android is for next week.


This change is Reviewable

@Frenzie
Copy link
Member Author

Frenzie commented Jun 3, 2022

Grr.

Luacheck results
/home/ko/local/bin/luajit
Checking ffi/SDL2_0.lua                           1 warning

    ffi/SDL2_0.lua:221:8: 'not (x > y)' can be replaced by 'x <= y' (if neither side is a table or NaN)

Checking ffi/mupdf.lua                            1 warning

    ffi/mupdf.lua:111:8: 'not (x > y)' can be replaced by 'x <= y' (if neither side is a table or NaN)

Checking ffi/rtc.lua                              2 warnings

    ffi/rtc.lua:259:8: 'not (x == y)' can be replaced by 'x ~= y' (if neither side is a table or NaN)
    ffi/rtc.lua:263:23: 'not (x == y)' can be replaced by 'x ~= y' (if neither side is a table or NaN)

Total: 4 warnings / 0 errors in 90 files

Exited with code exit status 1

@NiLuJe
Copy link
Member

NiLuJe commented Jun 3, 2022

That's from luacheck 0.26.1?

(I'm still on 0.25.0 locally, I'll look into it on Monday if nobody beats me to it).

@Frenzie
Copy link
Member Author

Frenzie commented Jun 4, 2022 via email

NiLuJe added a commit to NiLuJe/koreader-base that referenced this pull request Jun 6, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Jun 6, 2022
Frenzie pushed a commit that referenced this pull request Jun 8, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Jun 11, 2022
NiLuJe added a commit to koreader/koreader that referenced this pull request Jun 11, 2022
rjd22 pushed a commit to koreader/koreader that referenced this pull request Nov 7, 2022
@Frenzie Frenzie merged commit 49504f6 into master Apr 2, 2023
@Frenzie Frenzie deleted the Frenzie-patch-1 branch April 2, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants