thirdparty/sdcv v0.5.4

[Frenzie]

Dushistov/sdcv@v0.5.3...v0.5.4

Except of course we were on a slightly more recent commit, cf. #1431.

---

This change is 

[pazos]

this breaks dicts on android 😢

[Frenzie]

Huh, it does? Hold on, in that case let me post the fully accurate range of commits since our previous version.

Dushistov/sdcv@d054adb...v0.5.4

[Frenzie]

@pazos It seems that it doesn't actually, but something about the act of upgrading itself does.

[Frenzie]

That is,

Fresh KOReader 2022.06 install → dictionary (sdcv ?) works

Upgrade from 2022.05.1 (or any other version presumably) to 2022.06, dictionary/sdcv broken

So the problem doesn't lie in this PR/repo.

[pazos]

o_O

No real idea.

[Frenzie]

PS I haven't checked if it's something unique to that upgrade. I shouldn't imagine it is.

[pazos]

I will have a look in a couple of days. Too much device janitor for today 😄

[ilyats]

It seems so:
v2022.06 - works
v2022.06-9 - works if installed after removal of app or over v2022.06, does not work if installed over v2022.06-9 or v22.06-10
v2022.06-10 - does not work

[ilyats]

After update from release 2022.05.1 to either release 2022.06 or to nightbuild 2022.06-9 it works, after update from 2022.05.1 to nightbuild 2022.06.10 it doesn't

[Frenzie]

In that case, I would guess 2021.10 to 2021.11 should also fail. (I.e., the last time sdcv itself changed and wouldn't have been skipped by the extraction process.)

[ilyats]

v2022.06-12 does not work no matter how installed (just like v2022.06-10). Downgrading from v2022.06-12 to v2022.06-9 is not possible. v2022.06-.11 is absent on ota.koreader.rocks. вс, 3 июл. 2022 г. в 10:00, Frans de Jonge ***@***.***>:

…

In that case, I would guess 2021.10 to 2021.11 should also fail. — Reply to this email directly, view it on GitHub <#1495 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZBGMCPRAJMOHUJWYNKEITVSE3BDANCNFSM5ZYWN67A> . You are receiving this because you commented.Message ID: ***@***.***>

[ilyats]

It is possible to install v2022.06-09 over itself, and it breaks search, (while v2022.06-9 works when installed after removal of the app or over v2022.06), so the problem is not different libraries.

[Frenzie]

There's never a build for every single commit, only one per day.

Anyway, I'd overlooked that the buried not actually duplicate mentioned a change specifically post-stable. So then it is something in the commit diff above.