Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi add uppercase convert #1528

Merged
merged 1 commit into from
Oct 6, 2022
Merged

ffi add uppercase convert #1528

merged 1 commit into from
Oct 6, 2022

Conversation

weijiuqiao
Copy link
Contributor

@weijiuqiao weijiuqiao commented Oct 4, 2022

Use libutf8proc.utf8proc_toupper to convert string to uppercase.

Needed in Vietnamese keyboard.


This change is Reviewable

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm unless there's anything sneaky I'm missing. ^_^

@NiLuJe NiLuJe merged commit 41ff683 into koreader:master Oct 6, 2022
@weijiuqiao weijiuqiao deleted the vi_keyboard branch October 6, 2022 09:09
NiLuJe pushed a commit that referenced this pull request Oct 6, 2022
Co-authored-by: weijiuqiao <weijiuqiao.x@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants