PB Input: Handle EV_KEY & EV_MSC translations here, instead of in front #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of in front Also, handle key repeats while we're in there.
Frenzie
reviewed
Oct 28, 2022
| @@ -40,7 +40,7 @@ typedef struct real_iv_mtinfo_s { | |||
| * when indexing iv_mtinfo in the second slot the x and y will be wrong | |||
| * we currently fix this by making a real iv_mtinfo struct, this is dirty hack | |||
| * because of the lame API design of GetTouchInfo. It could be better to pass | |||
| * the slot paramter to GetTouchInfo which returns only one iv_mtinfo for that slot. */ | |||
| * the slot parameter to GetTouchInfo which returns only one iv_mtinfo for that slot. */ | |||
NiLuJe
commented
Oct 28, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Frenzie)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 28, 2022
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 28, 2022
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 29, 2022
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Oct 29, 2022
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes PB logs one billion percent less mysterious, and actually allows cleaning up some nastiness in front.
This change is