Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brew not found on non-Mac platforms #1594

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Apr 2, 2023

Follow-up to #1593


This change is Reviewable

@Frenzie Frenzie merged commit 14bb24f into koreader:master Apr 2, 2023
1 check passed
@Frenzie Frenzie deleted the better-fix branch April 2, 2023 20:55
@NiLuJe
Copy link
Member

NiLuJe commented Apr 2, 2023

That'll lead to a concat with a nil, won't it? (i.e., this should have an else that sets it to the empty string).

@NiLuJe
Copy link
Member

NiLuJe commented Apr 2, 2023

Oh, hey, it does. Never mind me :D.

@NiLuJe
Copy link
Member

NiLuJe commented Apr 2, 2023

Oh, right, I was looking at the diff from the first PR. At least I'm not going entirely barmy, that's reassuring :D.

@Frenzie
Copy link
Member Author

Frenzie commented Apr 2, 2023

Yeah, I wasn't paying close enough attention and I was also doing some experiments with Podman.

The tl;dr is you need something like this which I don't find very convenient (but I guess it's supposedly more secure, at least on a server):

podman unshare chown -R 1000:1000 koreader-for-building-android
podman run -v $(pwd)/koreader-for-building-android:/home/ko/koreader -it localhost/frans/koandroid:0.5.3 bash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants