Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship all the necessary webp dependencies #1634

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Jul 12, 2023

Newer versions depend on the internal libsharpyuv, ship it.

Fix koreader/koreader#10679 (comment)


This change is Reviewable

Newer versions depend on the internal libsharpyuv, ship it.

Fix koreader/koreader#10679 (comment)
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@poire-z
Copy link
Contributor

poire-z commented Jul 12, 2023

(No way to statically include it in the other libs ? It looks a bit unrelated with its name not mentionning "webp", and it is super small ?)

@NiLuJe
Copy link
Member Author

NiLuJe commented Jul 12, 2023

I really don't want to have to deal with the buildsystem for a static link, so, no ;o).

@NiLuJe NiLuJe merged commit 2707770 into koreader:master Jul 12, 2023
2 checks passed
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Jul 12, 2023
@Frenzie
Copy link
Member

Frenzie commented Jul 12, 2023

(No way to statically include it in the other libs ? It looks a bit unrelated with its name not mentionning "webp", and it is super small ?)

libwebp split it out for reasons that aren't completely clear to me. I guess someone asked for it.

webmproject/libwebp@29cc95c
webmproject/libwebp@841960b
webmproject/libwebp@a3b68c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on opening EPUB, HTML or RTF file
3 participants