Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call FullUpdateHQ to eliminate ghosting on Pocketbook #1752

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Call FullUpdateHQ to eliminate ghosting on Pocketbook #1752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88b2275
Call `FullUpdateHQ` to eliminate ghosting
dmalinovsky Mar 27, 2024
279a9d9
Run HQ update for color devices only
dmalinovsky Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion ffi/framebuffer_pocketbook.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ local function _updateFull(fb, x, y, w, h, dither)
_adjustAreaColours(fb)
end

inkview.FullUpdate()
if fb.device.hasColorScreen then
inkview.FullUpdateHQ()
else
inkview.FullUpdate()
Comment on lines +47 to +48
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During testing, I noticed that this does not result in a screen refresh on PocketBook devices without a color screen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't change anything for B&W Pocketbooks. Do you have full refresh turned on?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have full refresh turned on?

Yes, of course.

This PR doesn't change anything for B&W Pocketbooks.

Unfortunately, because of lines 45 and 46, B&W PocketBook devices now ignore line 48 for whatever reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe we need to explicitly set hasColorScreen to false. I've created koreader/koreader#11608 to address this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now I'm 99% sure #1757 should fix it. :)

end
end

local function _updateFast(fb, x, y, w, h, dither)
Expand Down